drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4152: Add trace logging to Parquet reade...
Date Mon, 14 Dec 2015 22:59:42 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/298#discussion_r47572637
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java
---
    @@ -196,7 +220,15 @@ public boolean next() throws IOException {
         // TODO - figure out if we need multiple dictionary pages, I believe it may be limited
to one
         // I think we are clobbering parts of the dictionary if there can be multiple pages
of dictionary
         do {
    +      long start=inputStream.getPos();
    +      timer.start();
           pageHeader = dataReader.readPageHeader();
    +      long timeToRead = timer.elapsed(TimeUnit.MICROSECONDS);
    +      this.updateStats(pageHeader, "Page Header Read", start, timeToRead, 0,0);
    +      logger.trace("ParquetTrace,{},{},{},{},{},{},{},{}","Page Header Read","",
    +          this.parentColumnReader.parentReader.hadoopPath,
    +          this.parentColumnReader.columnDescriptor.toString(), start, 0, 0, timeToRead);
    +      timer.reset();
    --- End diff --
    
    same here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message