drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4152: Add trace logging to Parquet reade...
Date Mon, 14 Dec 2015 18:23:18 GMT
Github user adeneche commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/PageReader.java
    @@ -124,9 +131,16 @@
       private void loadDictionaryIfExists(final ColumnReader<?> parentStatus,
           final ColumnChunkMetaData columnChunkMetaData, final FSDataInputStream f) throws
IOException {
    +    Stopwatch timer = new Stopwatch();
         if (columnChunkMetaData.getDictionaryPageOffset() > 0) {
    +      long start=f.getPos();
    +      timer.start();
           final PageHeader pageHeader = Util.readPageHeader(f);
    +      long timeToRead = timer.elapsed(TimeUnit.MICROSECONDS);
    +      timer.reset();
    --- End diff --
    no need to call `timer.reset()`

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message