drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adeneche <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4152: Add trace logging to Parquet reade...
Date Mon, 14 Dec 2015 18:19:10 GMT
Github user adeneche commented on a diff in the pull request:

    https://github.com/apache/drill/pull/298#discussion_r47534819
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetScanBatchCreator.java
---
    @@ -122,9 +124,14 @@ public ScanBatch getBatch(FragmentContext context, ParquetRowGroupScan
rowGroupS
           These fields will be added to the constructor below
           */
           try {
    +        Stopwatch timer = new Stopwatch();
             if ( ! footers.containsKey(e.getPath())){
    -          footers.put(e.getPath(),
    -              ParquetFileReader.readFooter(conf, new Path(e.getPath())));
    +          timer.start();
    +          ParquetMetadata footer = ParquetFileReader.readFooter(conf, new Path(e.getPath()));
    +          long timeToRead = timer.elapsed(TimeUnit.MICROSECONDS);
    +          timer.reset();
    --- End diff --
    
    we don't really need to call `timer.reset()` unless we move the timer creation outside
the for loop


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message