drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4134: Allocator updates
Date Mon, 14 Dec 2015 05:38:33 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/283#discussion_r47462869
  
    --- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
    @@ -287,14 +310,12 @@ public ByteOrder order() {
     
       @Override
       public ByteBuf order(ByteOrder endianness) {
    -    // if(endianness != ByteOrder.LITTLE_ENDIAN) throw new
    -    // UnsupportedOperationException("Drill buffers only support little endian.");
    --- End diff --
    
    This code breaks netty even though it shouldn't. We've had it commented out for years.
Just removing it now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message