drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4123: refer to fully qualified variable ...
Date Mon, 07 Dec 2015 22:54:45 GMT
Github user jaltekruse commented on the pull request:

    https://github.com/apache/drill/pull/293#issuecomment-162696095
  
    One other point here, the issue with fully qualified names actually shouldn't be a problem
in the usual usage of this function. The function was only designed to be evaluated at planning
time with the interpreter, not with the full code compilation model in the project operator.
While not ideal, the expected error that should be hit if this function is used in a select
list is here in the FragmentContext when we go to populate the injected PartitionExplorer.
https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/ops/FragmentContext.java#L458
    
    Has there been work to make partition pruning run the full code generation based expression
evaluation? I would consider anyone hitting code generation issues with this function to be
misusing it, I agree with fixing this poor error, but anyone executing this function outside
of partition pruning is going to be running a very expensive operation for each record in
their dataset and I can't think of a use case for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message