drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julienledem <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4134: Allocator updates
Date Tue, 01 Dec 2015 17:31:20 GMT
Github user julienledem commented on a diff in the pull request:

    https://github.com/apache/drill/pull/283#discussion_r46309586
  
    --- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
    @@ -431,12 +482,18 @@ public boolean equals(Object obj) {
       }
     
       @Override
    -  public synchronized ByteBuf retain(int increment) {
    -    if(rootBuffer){
    -      this.rootRefCnt.addAndGet(increment);
    -    }else{
    -      b.retain(increment);
    +  public ByteBuf retain(int increment) {
    --- End diff --
    
    how is this retain used compared to the other one (that takes an allocator)? Is this one
only used when in the same allocator?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message