Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E8196182A1 for ; Sun, 8 Nov 2015 17:37:04 +0000 (UTC) Received: (qmail 36474 invoked by uid 500); 8 Nov 2015 17:37:04 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 36421 invoked by uid 500); 8 Nov 2015 17:37:04 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 36409 invoked by uid 99); 8 Nov 2015 17:37:04 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 08 Nov 2015 17:37:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0067FC54FE for ; Sun, 8 Nov 2015 17:37:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.881 X-Spam-Level: ** X-Spam-Status: No, score=2.881 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=maprtech.com Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id LTqiaXL6dFhd for ; Sun, 8 Nov 2015 17:36:55 +0000 (UTC) Received: from mail-yk0-f173.google.com (mail-yk0-f173.google.com [209.85.160.173]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTPS id B79464419E for ; Sun, 8 Nov 2015 17:36:54 +0000 (UTC) Received: by ykdv3 with SMTP id v3so143019646ykd.0 for ; Sun, 08 Nov 2015 09:36:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maprtech.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=9aDf1ILagvgRb2swtcpk1MzFtlLfGzcz8L7gv+Mn1tw=; b=J7MWmyTqFAH7N0VJvDD+Vz/lvQ5y4Gkuzw4XXTdrdHJ3L+ZiqCPOPPSj7ybqeRw7tc UUTZJTLuP2ghphnWbLBYpp7p7k3QTUHGVKPB8lXlBjySsCWvz8PUwvCRE5UV4bPFhU/k nt2OxllPLfiGruLYv7EYN67n3EjFvD3JtSOzs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=9aDf1ILagvgRb2swtcpk1MzFtlLfGzcz8L7gv+Mn1tw=; b=ETX14O3JbzMYqciNfHhG/tPY0RJil+WoIu/D9Ix+FnQhDgjhr80vvoj3+IvkFscSSL FVxv7bMK7yfROSCrUGXslqIoYE8WeSkNkwGej9J20KQE1aCOnEL1n/Xv3U9f/znA3rF8 allxuvCMA5SaaevMv8YbKA6lBeBTu3PMNvlfigHZ34hU3zs6Iff/mvq9TU6eTCmpxfUF XWo5JC3Z0zGwIK0O1UQEUMnpLKnb52VrUhzSZ2QE1Gvwz8rRhaXDtI4qmPsYqqXq+kqX l1MUNDq47rGeelR6grl3nWXSdHgu6kRMvBSTUZAgMaZLRvKptQeZCJa/Yi0+vpJVHi7h 26IA== X-Gm-Message-State: ALoCoQnpd/D2qnQ/EilPW/XmnX85PTjgW0AiXm8/7eoWCl2H1Jh2YjOjfBA5ZWobxu/nCJ44/hEH MIME-Version: 1.0 X-Received: by 10.13.199.130 with SMTP id j124mr13349105ywd.70.1447004214322; Sun, 08 Nov 2015 09:36:54 -0800 (PST) Received: by 10.129.109.136 with HTTP; Sun, 8 Nov 2015 09:36:54 -0800 (PST) In-Reply-To: References: Date: Sun, 8 Nov 2015 09:36:54 -0800 Message-ID: Subject: Re: Zookeeper down before query starts/after query finishes From: Hsuan Yi Chu To: dev@drill.apache.org Content-Type: multipart/alternative; boundary=001a114da6ea2f2c6f05240aec25 --001a114da6ea2f2c6f05240aec25 Content-Type: text/plain; charset=UTF-8 I just submitted a pull request to address DRILL-3751, which focuses on the scenario where query already finishes and zookeeper dies. So Foreman cannot delete the profiles of running queries in zookeeper. I think in this case, after a few retries, Foreman can assume Zookeeper is down. And, this query is assumed to fail since client might not be able to receive the result (see the behavior in DRILL-3751 ). Does this make sense? On Fri, Nov 6, 2015 at 10:43 AM, Hsuan Yi Chu wrote: > My understanding is : > Before query starts/After query finishes, Foreman will put/delete running > query profiles in zookeeper. > > However, if zookeeper is down before the put/delete is successful, Drill > would be blocked at the put/delete operation. > > See https://issues.apache.org/jira/browse/DRILL-3751 > > I think it is not quite right to let Drill just wait for Zookeeper to > respond. Does it make sense to use "time-out" here? > > > --001a114da6ea2f2c6f05240aec25--