Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 161CA18BAA for ; Tue, 17 Nov 2015 22:19:53 +0000 (UTC) Received: (qmail 25391 invoked by uid 500); 17 Nov 2015 22:19:52 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 25336 invoked by uid 500); 17 Nov 2015 22:19:52 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 25325 invoked by uid 99); 17 Nov 2015 22:19:52 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Nov 2015 22:19:52 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 79131DFF7E; Tue, 17 Nov 2015 22:19:52 +0000 (UTC) From: hsuanyi To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request: DRILL-3854: For convert_from, re-point readerI... Content-Type: text/plain Message-Id: <20151117221952.79131DFF7E@git1-us-west.apache.org> Date: Tue, 17 Nov 2015 22:19:52 +0000 (UTC) Github user hsuanyi commented on the pull request: https://github.com/apache/drill/pull/262#issuecomment-157528584 Thanks for that. I also looked through the implementations of getBuffers(). As long as that in BaseDataValueVector obeys, the derived ones should follow the contract --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---