Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5BF2D18A62 for ; Mon, 16 Nov 2015 05:35:52 +0000 (UTC) Received: (qmail 23187 invoked by uid 500); 16 Nov 2015 05:35:47 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 23137 invoked by uid 500); 16 Nov 2015 05:35:47 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 23126 invoked by uid 99); 16 Nov 2015 05:35:46 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 16 Nov 2015 05:35:46 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id A938ADFBC7; Mon, 16 Nov 2015 05:35:46 +0000 (UTC) From: jacques-n To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request: DRILL-4081: Handle schema changes in ExternalS... Content-Type: text/plain Message-Id: <20151116053546.A938ADFBC7@git1-us-west.apache.org> Date: Mon, 16 Nov 2015 05:35:46 +0000 (UTC) Github user jacques-n commented on the pull request: https://github.com/apache/drill/pull/257#issuecomment-156919949 I think it is fine if you handle the unsupported map behaviors with a clear user exception. Other than the refactoring of getFieldId (if possible), LGTM. +1. (Assuming that this functionality only changes system behavior in the case that Union vector is enabled.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---