Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: amansinha100 <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-222-drill@git.apache.org>
In-Reply-To: <git-pr-222-drill@git.apache.org>
Subject: [GitHub] drill pull request: Drill 3952
Content-Type: text/plain
Message-Id: <20151101193024.E466ADFCC0@git1-us-west.apache.org>
Date: Sun,  1 Nov 2015 19:30:24 +0000 (UTC)

Github user amansinha100 commented on the pull request:

    https://github.com/apache/drill/pull/222#issuecomment-152853864
  
    Overall,  there are 2 categories of the window functions: one that require all batches of the partition before they can start processing and second that can start work with partial partition as long as we have all peer rows of the current row.   It seems to me that some refactoring is needed to have derived classes dedicated to the 2 categories, otherwise  the logic in the common code is getting complicated.  What do you think ?  This need not necessarily be done as part of this patch...but we should discuss. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---