drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3854: For convert_from, re-point readerI...
Date Sat, 21 Nov 2015 04:09:29 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/262#discussion_r45541183
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/memory/TestAllocators.java
---
    @@ -63,6 +69,53 @@
       private final static String planFile="/physical_allocator_test.json";
     
       @Test
    +  public void testDrillBufReadIndex() throws Exception {
    --- End diff --
    
    Maybe name ensureDrillBufReadIndexIsZero or add a new javadoc


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message