drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3854: For convert_from, re-point readerI...
Date Fri, 20 Nov 2015 17:11:40 GMT
Github user jacques-n commented on the pull request:

    https://github.com/apache/drill/pull/262#issuecomment-158462636
  
    lgtm.
    
    Do you want to add a unit test that verifies the buffer reader index == zero behavior
in addition to the integration-ish test you added? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message