drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4015: Update DrillClient and JDBC driver...
Date Thu, 19 Nov 2015 17:11:55 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/263#discussion_r45370022
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/Foreman.java
---
    @@ -192,6 +196,32 @@ public QueryManager getQueryManager() {
       }
     
       /**
    +   * Collect warnings messages from all fragments and store them in QueryWarning
    +   * @param warnings warning message from a fragment
    +   */
    +  public void addQueryWarnings (List<WarningMsg> warnings) {
    --- End diff --
    
    Need to propose an approach around thread safety guarantees here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message