drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hnfgns <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3171: handle concurrent Zookeeper node c...
Date Thu, 19 Nov 2015 00:58:20 GMT
Github user hnfgns commented on a diff in the pull request:

    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/sys/zk/ZkAbstractStore.java
    @@ -54,31 +59,26 @@ public ZkAbstractStore(CuratorFramework framework, PStoreConfig<V>
         this.prefix = parent + "/";
         this.framework = framework;
         this.config = config;
    +    this.childrenCache = new PathChildrenCache(framework, parent, true);
    --- End diff --
    I consistently use `this` (i) in c'tor assignments or (ii) if there is any shadowing variable.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.

View raw message