drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From parthchandra <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4015: Update DrillClient and JDBC driver...
Date Wed, 18 Nov 2015 18:31:54 GMT
Github user parthchandra commented on a diff in the pull request:

    https://github.com/apache/drill/pull/263#discussion_r45239402
  
    --- Diff: protocol/src/main/protobuf/User.proto ---
    @@ -27,6 +27,7 @@ enum RpcType {
       RESP_FUNCTION_LIST = 9;
     
       QUERY_RESULT = 10; // drillbit is reporting a query status change, most likely a terminal
message, to the user
    +  QUERY_WARNING = 12; // drillbit is sending a query warning to the user
    --- End diff --
    
    If we include this, we will break the ODBC client backward compatibility. It would be
best to leave this out and include a warning object optionally in the QueryResult. Older clients
will be able to handle this, they just won't return a warning to the application. Newer clients
can be updated to return a warning to the application. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message