drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3765: Move partitioning pruning to HepPl...
Date Mon, 16 Nov 2015 21:46:38 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/255#discussion_r44988307
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
---
    @@ -116,20 +117,32 @@ public DrillSqlWorker(QueryContext context) {
     
       private RuleSet[] getRules(QueryContext context) {
         StoragePluginRegistry storagePluginRegistry = context.getStorage();
    -    RuleSet drillLogicalRules = DrillRuleSets.mergedRuleSets(
    +
    +    // Ruleset for the case where VolcanoPlanner is used for everything : join, filter/project
pushdown, partition pruning.
    +    RuleSet drillLogicalVolOnlyRules = DrillRuleSets.mergedRuleSets(
             DrillRuleSets.getDrillBasicRules(context),
    +        DrillRuleSets.getPruneScanRules(context),
             DrillRuleSets.getJoinPermRules(context),
             DrillRuleSets.getDrillUserConfigurableLogicalRules(context));
    +
    +    // Ruleset for the case where join planning is done in Hep-LOPT, filter/project pushdown
and parttion pruning are done in VolcanoPlanner
    +    RuleSet drillLogicalHepJoinRules = DrillRuleSets.mergedRuleSets(
    +        DrillRuleSets.getDrillBasicRules(context),
    +        DrillRuleSets.getPruneScanRules(context),
    +        DrillRuleSets.getDrillUserConfigurableLogicalRules(context));
    +
    +    // Ruleset for the case where join planning and partition pruning is done in Hep,
filter/project pushdown are done in VolcanoPlanner
    --- End diff --
    
    Ok, I see.   
    LGTM +1.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message