drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4081: Handle schema changes in ExternalS...
Date Mon, 16 Nov 2015 05:35:46 GMT
Github user jacques-n commented on the pull request:

    https://github.com/apache/drill/pull/257#issuecomment-156919949
  
    I think it is fine if you handle the unsupported map behaviors with a clear user exception.
Other than the refactoring of getFieldId (if possible), LGTM. +1.  (Assuming that this functionality
only changes system behavior in the case that Union vector is enabled.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message