drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4081: Handle schema changes in ExternalS...
Date Mon, 16 Nov 2015 02:12:43 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/257#discussion_r44883694
  
    --- Diff: exec/vector/src/main/java/org/apache/drill/exec/vector/complex/FieldIdUtil.java
---
    @@ -121,4 +125,63 @@ public static TypedFieldId getFieldIdIfMatches(ValueVector vector,
TypedFieldId.
           }
         }
       }
    +
    +  public static TypedFieldId getFieldId(ValueVector vector, int id, SchemaPath expectedPath,
boolean hyper) {
    --- End diff --
    
    Is it possible to share this code (or much of it with getFieldIdIfMatches() above). It
seems like they are related (although I didn't go line by line)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message