drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-4082: Better error message when multiple...
Date Thu, 12 Nov 2015 22:32:08 GMT
Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/252#discussion_r44725024
  
    --- Diff: common/src/main/java/org/apache/drill/common/scanner/ClassPathScanner.java ---
    @@ -422,11 +423,16 @@ static ScanResult scan(Collection<URL> pathsToScan, Collection<String>
packagePr
         }
       }
     
    -  private static void verifyClassUnicity(List<AnnotatedClassDescriptor> annotatedClasses)
{
    +  private static void verifyClassUnicity(List<AnnotatedClassDescriptor> annotatedClasses,
Collection<URL> pathsScanned) {
         Set<String> scanned = new HashSet<>();
         for (AnnotatedClassDescriptor annotated : annotatedClasses) {
           if (!scanned.add(annotated.getClassName())) {
    -        throw new RuntimeException("BUG: " + annotated.getClassName() + " scanned twice");
    +        throw UserException.functionError()
    +            .message(
    +                "function %s scanned twice in %s\nDo you have conflicting jars on the
classpath?",
    +                annotated.getClassName(), pathsScanned
    --- End diff --
    
    Did you mean to print a list of the URLs? Wouldn't this require use of a Joiner to serialize
the collection?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message