drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From hnfgns <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...
Date Fri, 06 Nov 2015 23:24:45 GMT
Github user hnfgns commented on a diff in the pull request:

    https://github.com/apache/drill/pull/245#discussion_r44199009
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/IteratorValidatorBatchIterator.java
---
    @@ -33,36 +33,113 @@
     import org.apache.drill.exec.util.BatchPrinter;
     import org.apache.drill.exec.vector.VectorValidator;
     
    +import static org.apache.drill.exec.record.RecordBatch.IterOutcome.*;
    +
    +
     public class IteratorValidatorBatchIterator implements CloseableRecordBatch {
    -  static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(IteratorValidatorBatchIterator.class);
    +  private static final org.slf4j.Logger logger =
    +      org.slf4j.LoggerFactory.getLogger(IteratorValidatorBatchIterator.class);
     
       static final boolean VALIDATE_VECTORS = false;
     
    -  private IterOutcome state = IterOutcome.NOT_YET;
    +  /** For logging/debuggability only. */
    +  private static volatile int instanceCount;
    +
    +  /** For logging/debuggability only. */
    +  private final int instNum;
    +  {
    +    instNum = ++instanceCount;
    +  }
    +
    +  /**
    +   * The upstream batch, calls to which and return values from which are
    +   * checked by this validator.
    +   */
       private final RecordBatch incoming;
    -  private boolean first = true;
    +
    +  /** Incoming batch's type (simple class name); for logging/debuggability
    +   *  only. */
    +  private final String batchTypeName;
    +
    +  /** Exception state of incoming batch; last value thrown by its next()
    +   *  method. */
    +  private Throwable exceptionState = null;
    +
    +  /** Main state of incoming batch; last value returned by its next() method. */
    +  private IterOutcome batchState = null;
    +
    +  /** Last schema retrieved after OK_NEW_SCHEMA or OK from next().  Null if none
    +   *  yet. Currently for logging/debuggability only. */
    +  private BatchSchema lastSchema = null;
    +
    +  /** Last schema retrieved after OK_NEW_SCHEMA from next().  Null if none yet.
    +   *  Currently for logging/debuggability only. */
    --- End diff --
    
    pretty good doc here :100: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message