drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From amansinha100 <...@git.apache.org>
Subject [GitHub] drill pull request: Drill 3952
Date Tue, 03 Nov 2015 18:52:45 GMT
Github user amansinha100 commented on a diff in the pull request:

    https://github.com/apache/drill/pull/222#discussion_r43789532
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/window/WindowFramer.java
---
    @@ -38,19 +40,33 @@ void setup(final List<WindowDataBatch> batches, final VectorContainer
container,
       void doWork() throws DrillException;
     
       /**
    -   * check if current batch can be processed:
    -   * <ol>
    -   *   <li>we have at least 2 saved batches</li>
    -   *   <li>last partition of current batch ended</li>
    -   * </ol>
    -   * @return true if current batch can be processed, false otherwise
    -   */
    -  boolean canDoWork();
    -
    -  /**
        * @return number rows processed in last batch
        */
       int getOutputCount();
     
       void cleanup();
    +
    +  /**
    +   * compares two rows from different batches (can be the same), if they have the same
value for the partition by
    +   * expression
    +   * @param b1Index index of first row
    +   * @param b1 batch for first row
    +   * @param b2Index index of second row
    +   * @param b2 batch for second row
    +   * @return true if the rows are in the same partition
    +   */
    +  boolean isSamePartition(@Named("b1Index") int b1Index, @Named("b1") VectorAccessible
b1,
    +                                          @Named("b2Index") int b2Index, @Named("b2")
VectorAccessible b2);
    +
    +  /**
    +   * compares two rows from different batches (can be the same), if they have the same
value for the order by
    +   * expression
    +   * @param b1Index index of first row
    +   * @param b1 batch for first row
    +   * @param b2Index index of second row
    +   * @param b2 batch for second row
    +   * @return true if the rows are in the same partition
    --- End diff --
    
    change to 'rows in the same partition and are peers'


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message