drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...
Date Tue, 03 Nov 2015 05:25:54 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/228#discussion_r43717313
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/fn/JsonReader.java
---
    @@ -93,13 +93,15 @@ public void ensureAtLeastOneField(ComplexWriter writer) {
         if (!atLeastOneWrite) {
           // if we had no columns, create one empty one so we can return some data for count
purposes.
           SchemaPath sp = columns.get(0);
    -      PathSegment root = sp.getRootSegment();
    +      PathSegment fieldPath = sp.getRootSegment();
           BaseWriter.MapWriter fieldWriter = writer.rootAsMap();
    -      while (root.getChild() != null && !root.getChild().isArray()) {
    -        fieldWriter = fieldWriter.map(root.getNameSegment().getPath());
    -        root = root.getChild();
    +      while (fieldPath.getChild() != null && ! fieldPath.getChild().isArray())
{
    +        fieldWriter = fieldWriter.map(fieldPath.getNameSegment().getPath());
    +        fieldPath = fieldPath.getChild();
    +      }
    +      if (fieldWriter.isEmptyMap()) {
    --- End diff --
    
    The change I was focused on was the addition of the fieldWriter.isEmptyMap() condition.
Why was this condition added to the code?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message