drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-951:CSV header row should be parsed
Date Tue, 03 Nov 2015 04:55:36 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/232#discussion_r43716119
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/TextParsingSettings.java
---
    @@ -57,6 +56,14 @@ public void set(TextFormatConfig config){
         this.delimiter = bSafe(config.getFieldDelimiter(), "fieldDelimiter");
         this.comment = bSafe(config.getComment(), "comment");
         this.skipFirstLine = config.isSkipFirstLine();
    +    //TODO: avoid specific extension based check
    --- End diff --
    
    You can make this work correctly by using a format plugin config. You can add csvh here:
    
    https://github.com/apache/drill/blob/master/exec/java-exec/src/main/resources/bootstrap-storage-plugins.json
    
    Basically, create a new item in the map. Note how the text formats are a subset of the
TextFormatConfig class. You can add a new property that tells you to perform header extraction.
See the properties here [1] that correspond to the format properties: [1] https://github.com/apache/drill/blob/master/exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/TextFormatPlugin.java#L134


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message