drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StevenMPhillips <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3912: Common subexpression elimination
Date Tue, 03 Nov 2015 04:23:29 GMT
Github user StevenMPhillips commented on a diff in the pull request:

    https://github.com/apache/drill/pull/189#discussion_r43715208
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java
---
    @@ -218,11 +220,16 @@ public HoldingContainer addExpr(LogicalExpression ex) {
       }
     
       public HoldingContainer addExpr(LogicalExpression ex, boolean rotate) {
    +    return addExpr(ex, rotate, false);
    --- End diff --
    
    I actually think I will just remove the boolean flag altogether. Originally I wanted to
limit the scope, but I think it makes sense to always have it enabled.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message