drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jinfengni <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3912: Common subexpression elimination
Date Tue, 03 Nov 2015 04:05:13 GMT
Github user jinfengni commented on a diff in the pull request:

    https://github.com/apache/drill/pull/189#discussion_r43714617
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/ClassGenerator.java
---
    @@ -218,11 +220,16 @@ public HoldingContainer addExpr(LogicalExpression ex) {
       }
     
       public HoldingContainer addExpr(LogicalExpression ex, boolean rotate) {
    +    return addExpr(ex, rotate, false);
    --- End diff --
    
    I think this had better to be addExpr(ex, rotate, true). That is, be default, we turn
on CSE. Otherwise, seems the patch only turns on CSE for Project, Filter, HashAgg, HashJoin,
but not for other operators. 
    
    Is there any reason that we do not by default turn on CSE here?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message