drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mehant <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3941: Add timing instrumentation in diff...
Date Tue, 03 Nov 2015 01:12:45 GMT
Github user mehant commented on a diff in the pull request:

    https://github.com/apache/drill/pull/230#discussion_r43706628
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
    @@ -163,7 +163,9 @@ private ParquetTableMetadata_v1 getParquetTableMetadata(String path)
throws IOEx
         watch.start();
         List<FileStatus> fileStatuses = getFileStatuses(fileStatus);
         logger.info("Took {} ms to get file statuses", watch.elapsed(TimeUnit.MILLISECONDS));
    -    return getParquetTableMetadata(fileStatuses);
    +    ParquetTableMetadata_v1 metadata_v1 = getParquetTableMetadata(fileStatuses);
    +    logger.info("Took {} ms to read file metadata", watch.elapsed(TimeUnit.MILLISECONDS));
    --- End diff --
    
    I will modify this to exclude the getFileStatuses(). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message