drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsbos <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...
Date Tue, 03 Nov 2015 00:40:33 GMT
Github user dsbos commented on a diff in the pull request:

    https://github.com/apache/drill/pull/228#discussion_r43704529
  
    --- Diff: contrib/storage-hbase/src/main/java/org/apache/drill/exec/store/hbase/HBaseRecordReader.java
---
    @@ -142,10 +148,12 @@ public void setup(OperatorContext context, OutputMutator output)
throws Executio
               getOrCreateFamilyVector(column.getRootSegment().getPath(), false);
             }
           }
    -      logger.debug("Opening scanner for HBase table '{}', Zookeeper quorum '{}', port
'{}', znode '{}'.",
    -          hbaseTableName, hbaseConf.get(HConstants.ZOOKEEPER_QUORUM),
    -          hbaseConf.get(HBASE_ZOOKEEPER_PORT), hbaseConf.get(HConstants.ZOOKEEPER_ZNODE_PARENT));
    -      hTable = new HTable(hbaseConf, hbaseTableName);
    +      // Add vector for any column families not mentioned yet (in order to avoid
    +      // creation of dummy NullableIntVectors for them).
    +      for (HColumnDescriptor columnFamily :
    --- End diff --
    
    Created DRILL-4010 and added unit test (currently ignored) for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message