drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsbos <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...
Date Mon, 02 Nov 2015 18:44:20 GMT
Github user dsbos commented on a diff in the pull request:

    https://github.com/apache/drill/pull/228#discussion_r43664058
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
    @@ -335,7 +343,8 @@ public IterOutcome nextBatch() throws SchemaChangeException {
                 return iterRight;
     
               default:
    -            throw new IllegalStateException(String.format("Unknown state %s.", iterRight));
    +            throw new IllegalStateException(
    --- End diff --
    
    Hmm.  It's been a while, so I don't recall exactly.  It looks like I wrapped it to fit
within 80 columns since most of the code and comments just above fit within that width.  (Yes,
now I see that the next throw statement below is also wider.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message