drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dsbos <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...
Date Mon, 02 Nov 2015 18:24:24 GMT
Github user dsbos commented on a diff in the pull request:

    https://github.com/apache/drill/pull/228#discussion_r43661592
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/record/RecordBatch.java ---
    @@ -23,60 +23,214 @@
     import org.apache.drill.exec.record.selection.SelectionVector4;
     
     /**
    - * A record batch contains a set of field values for a particular range of records. In
the case of a record batch
    - * composed of ValueVectors, ideally a batch fits within L2 cache (~256k per core). The
set of value vectors do not
    - * change unless the next() IterOutcome is a *_NEW_SCHEMA type.
    - *
    - * A key thing to know is that the Iterator provided by record batch must align with
the rank positions of the field ids
    - * provided utilizing getValueVectorId();
    + * A record batch contains a set of field values for a particular range of
    --- End diff --
    
    Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message