drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-2288: Fix ScanBatch violation of IterOut...
Date Mon, 02 Nov 2015 05:26:31 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/228#discussion_r43597968
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractMapVector.java
---
    @@ -189,8 +189,8 @@ protected void putVector(String name, ValueVector vector) {
             Preconditions.checkNotNull(vector, "vector cannot be null")
         );
         if (old != null && old != vector) {
    -      logger.debug("Field [%s] mutated from [%s] to [%s]", name, old.getClass().getSimpleName(),
    -          vector.getClass().getSimpleName());
    +      logger.debug("Field [{}] mutated from [{}] to [{}]", name, old.getClass().getSimpleName(),
    --- End diff --
    
    I think there is a limit to the number of bracket replacements on the logger interface.
Is three allowed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message