Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: jacques-n <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-207-drill@git.apache.org>
In-Reply-To: <git-pr-207-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-3232: Handle promoting writers and
 vecto...
Content-Type: text/plain
Message-Id: <20151030052108.10FE3DF9AA@git1-us-west.apache.org>
Date: Fri, 30 Oct 2015 05:21:08 +0000 (UTC)

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/207#discussion_r43472622
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/AbstractMapVector.java ---
    @@ -173,7 +173,7 @@ public ValueVector getChildByOrdinal(int id) {
        *
        * Note that this method does not enforce any vector type check nor throws a schema change exception.
        */
    -  protected void putChild(String name, ValueVector vector) {
    +  public void putChild(String name, ValueVector vector) {
         putVector(name, vector);
    --- End diff --
    
    If we're making this more public, isn't there some way we can verify that what is being loaded is right? Also, why isn't protected enough?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---