Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: jacques-n <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-207-drill@git.apache.org>
In-Reply-To: <git-pr-207-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-3232: Handle promoting writers and
 vecto...
Content-Type: text/plain
Message-Id: <20151030051159.3AB35DF9AA@git1-us-west.apache.org>
Date: Fri, 30 Oct 2015 05:11:59 +0000 (UTC)

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/207#discussion_r43472317
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/HashAggBatch.java ---
    @@ -211,6 +212,10 @@ private HashAggregator createAggregatorInternal() throws SchemaChangeException,
           final LogicalExpression expr =
               ExpressionTreeMaterializer.materialize(ne.getExpr(), incoming, collector, context.getFunctionRegistry());
     
    +      if (expr instanceof IfExpression) {
    +        throw new SchemaChangeException("Union type not supported in aggregate functions");
    --- End diff --
    
    Let's use UserException.Unsupported


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---