Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: cwestin <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-199-drill@git.apache.org>
In-Reply-To: <git-pr-199-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-3927: use OutOfMemoryException in
 more p...
Content-Type: text/plain
Message-Id: <20151014180113.D4AE7E0523@git1-us-west.apache.org>
Date: Wed, 14 Oct 2015 18:01:13 +0000 (UTC)

Github user cwestin commented on a diff in the pull request:

    https://github.com/apache/drill/pull/199#discussion_r42028942
  
    --- Diff: common/src/main/java/org/apache/drill/common/DrillAutoCloseables.java ---
    @@ -0,0 +1,50 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.drill.common;
    +
    +/**
    + * Provides functionality comparable to Guava's Closeables for AutoCloseables.
    + */
    +public class DrillAutoCloseables {
    +  /**
    +   * Constructor. Prevents construction for class of static utilities.
    +   */
    +  private DrillAutoCloseables() {
    +  }
    +
    +  /**
    +   * close() an {@see java.lang.AutoCloseable} without throwing a (checked)
    +   * {@see java.lang.Exception}. This wraps the close() call with a
    +   * try-catch that will rethrow an Exception wrapped with a
    +   * {@see java.lang.RuntimeException}, providing a way to call close()
    +   * without having to do the try-catch everywhere or propagate the Exception.
    +   *
    +   * @param closeable the AutoCloseable to close; may be null
    +   * @throws RuntimeException if an Exception occurs; the Exception is
    +   *   wrapped by the RuntimeException
    +   */
    +  public static void closeNoChecked(final AutoCloseable autoCloseable) {
    --- End diff --
    
    My plan was to merge those two files once I'm done -- and only leave one of them. They were created in two different sets of work for the same purpose. Can we do that later?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---