Return-Path: X-Original-To: apmail-drill-dev-archive@www.apache.org Delivered-To: apmail-drill-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 28674184AB for ; Tue, 13 Oct 2015 23:11:07 +0000 (UTC) Received: (qmail 13043 invoked by uid 500); 13 Oct 2015 23:10:55 -0000 Delivered-To: apmail-drill-dev-archive@drill.apache.org Received: (qmail 12984 invoked by uid 500); 13 Oct 2015 23:10:55 -0000 Mailing-List: contact dev-help@drill.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@drill.apache.org Delivered-To: mailing list dev@drill.apache.org Received: (qmail 12973 invoked by uid 99); 13 Oct 2015 23:10:55 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2015 23:10:55 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 60E38E01F5; Tue, 13 Oct 2015 23:10:55 +0000 (UTC) From: julienledem To: dev@drill.apache.org Reply-To: dev@drill.apache.org References: In-Reply-To: Subject: [GitHub] drill pull request: DRILL-3742: Classpath scanning Content-Type: text/plain Message-Id: <20151013231055.60E38E01F5@git1-us-west.apache.org> Date: Tue, 13 Oct 2015 23:10:55 +0000 (UTC) Github user julienledem commented on a diff in the pull request: https://github.com/apache/drill/pull/148#discussion_r41938462 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/expr/fn/HiveFunctionRegistry.java --- @@ -53,12 +54,14 @@ * @param config */ public HiveFunctionRegistry(DrillConfig config) { - Set> genericUDFClasses = PathScanner.scanForImplementations(GenericUDF.class, null); + // TODO: see if we can avoid this. We can't change the constructor right now. + ScanResult classpathScan = ClassPathScanner.fromPrescan(config); --- End diff -- no because fromPrescan has a cache (it keeps track of the last scan and reuses it if we ask for the same thing), but that's far from ideal. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---