Return-Path: 
 <dev-return-17261-apmail-drill-dev-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-dev-archive@www.apache.org
Delivered-To: apmail-drill-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 6D28E18B6E
	for <apmail-drill-dev-archive@www.apache.org>;
 Tue, 13 Oct 2015 00:49:52 +0000 (UTC)
Received: (qmail 28068 invoked by uid 500); 13 Oct 2015 00:49:39 -0000
Delivered-To: apmail-drill-dev-archive@drill.apache.org
Received: (qmail 28019 invoked by uid 500); 13 Oct 2015 00:49:39 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 28008 invoked by uid 99); 13 Oct 2015 00:49:39 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2015 00:49:39 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 33A33E0451; Tue, 13 Oct 2015 00:49:39 +0000 (UTC)
From: jacques-n <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-197-drill@git.apache.org>
In-Reply-To: <git-pr-197-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-3921: Initialize the underlying
 record r...
Content-Type: text/plain
Message-Id: <20151013004939.33A33E0451@git1-us-west.apache.org>
Date: Tue, 13 Oct 2015 00:49:39 +0000 (UTC)

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/197#discussion_r41817087
  
    --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveRecordReader.java ---
    @@ -223,6 +228,24 @@ private void init() throws ExecutionSetupException {
       @Override
       public void setup(@SuppressWarnings("unused") OperatorContext context, OutputMutator output)
           throws ExecutionSetupException {
    +    final ListenableFuture<Void> result = context.runCallableAs(proxyUgi,
    +      new Callable<Void>() {
    +        @Override
    +        public Void call() throws Exception {
    +          init();
    +          return null;
    +        }
    +      });
    +    try {
    +      result.get();
    +    } catch (InterruptedException e) {
    +      result.cancel(true);
    +      // Preserve evidence that the interruption occurred so that code higher up on the call stack can learn of the
    +      // interruption and respond to it if it wants to.
    +      Thread.currentThread().interrupt();
    --- End diff --
    
    You're right. See, I accidentally reinforced my point around the anonymous object... :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---