Return-Path: 
 <dev-return-17227-apmail-drill-dev-archive=drill.apache.org@drill.apache.org>
X-Original-To: apmail-drill-dev-archive@www.apache.org
Delivered-To: apmail-drill-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 5F78D188D7
	for <apmail-drill-dev-archive@www.apache.org>;
 Mon, 12 Oct 2015 18:09:56 +0000 (UTC)
Received: (qmail 4007 invoked by uid 500); 12 Oct 2015 18:09:49 -0000
Delivered-To: apmail-drill-dev-archive@drill.apache.org
Received: (qmail 3954 invoked by uid 500); 12 Oct 2015 18:09:49 -0000
Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@drill.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@drill.apache.org>
List-Post: <mailto:dev@drill.apache.org>
List-Id: <dev.drill.apache.org>
Reply-To: dev@drill.apache.org
Delivered-To: mailing list dev@drill.apache.org
Received: (qmail 3943 invoked by uid 99); 12 Oct 2015 18:09:49 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org)
 (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Oct 2015 18:09:49 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at
 git1-us-west.apache.org, from userid 33)
	id 4F13BE03E8; Mon, 12 Oct 2015 18:09:49 +0000 (UTC)
From: jacques-n <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-197-drill@git.apache.org>
In-Reply-To: <git-pr-197-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-3921: Initialize the underlying
 record r...
Content-Type: text/plain
Message-Id: <20151012180949.4F13BE03E8@git1-us-west.apache.org>
Date: Mon, 12 Oct 2015 18:09:49 +0000 (UTC)

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/197#discussion_r41784124
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/OperatorContextImpl.java ---
    @@ -130,6 +134,60 @@ public OperatorStats getStats() {
         return stats;
       }
     
    +
    --- End diff --
    
    Can we move create a pool for these delegate threads? The default can be empty but we'll expand as needed. We also need to think about interruptions and errors. It might be better if the actual method interface is Future<Result> and we allow the implementor pick when to block. Guava has a abstract checked future that would probably solve most of these needs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---