Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: jacques-n <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-148-drill@git.apache.org>
In-Reply-To: <git-pr-148-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-3742: Classpath scanning
Content-Type: text/plain
Message-Id: <20151012004629.800AADFF1B@git1-us-west.apache.org>
Date: Mon, 12 Oct 2015 00:46:29 +0000 (UTC)

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/148#discussion_r41718323
  
    --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/expr/fn/HiveFunctionRegistry.java ---
    @@ -53,12 +54,14 @@
        * @param config
        */
       public HiveFunctionRegistry(DrillConfig config) {
    -    Set<Class<? extends GenericUDF>> genericUDFClasses = PathScanner.scanForImplementations(GenericUDF.class, null);
    +    // TODO: see if we can avoid this. We can't change the constructor right now.
    +    ScanResult classpathScan = ClassPathScanner.fromPrescan(config);
    --- End diff --
    
    Doesn't this cause a second scan?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---