Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: jacques-n <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-190-drill@git.apache.org>
In-Reply-To: <git-pr-190-drill@git.apache.org>
Subject: [GitHub] drill pull request: Initial version of RecordIterator and
 MergeJoi...
Content-Type: text/plain
Message-Id: <20151012002057.A3996DFE61@git1-us-west.apache.org>
Date: Mon, 12 Oct 2015 00:20:57 +0000 (UTC)

Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/190#discussion_r41717983
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java ---
    @@ -403,14 +325,14 @@ private JoinWorker generateNewWorker() throws ClassTransformationException, IOEx
               outputType = inputType;
             }
             JVar vvIn = cg.declareVectorValueSetupAndMember("incomingLeft",
    -                                                        new TypedFieldId(inputType, vectorId));
    +          new TypedFieldId(inputType, vectorId));
    --- End diff --
    
    Can you look if we can factor this out? I believe we have a utility method that builds vector to vector copies rather than by doing it manually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---