Mailing-List: contact dev-help@drill.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@drill.apache.org
From: sudheeshkatkam <git@git.apache.org>
To: dev@drill.apache.org
Reply-To: dev@drill.apache.org
References: <git-pr-159-drill@git.apache.org>
In-Reply-To: <git-pr-159-drill@git.apache.org>
Subject: [GitHub] drill pull request: DRILL-1065: Support for ALTER ... RESET
 statem...
Content-Type: text/plain
Message-Id: <20151001021215.B7F81E03BE@git1-us-west.apache.org>
Date: Thu,  1 Oct 2015 02:12:15 +0000 (UTC)

Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/159#discussion_r40873825
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/options/TypeValidators.java ---
    @@ -179,6 +181,7 @@ public void validate(final OptionValue v) {
     
         public TypeValidator(final String name, final Kind kind, final OptionValue defValue) {
           super(name);
    +      checkArgument(defValue.type == OptionType.SYSTEM, "Default value must be SYSTEM type.");
    --- End diff --
    
    This check is when a TypeValidator (static instance) is created, so developers know not to create a validator with non SYSTEM level option type. Nothing to do with usage. Right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---