drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vkorukanti <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3938: Support reading from Hive tables t...
Date Tue, 20 Oct 2015 15:16:49 GMT
GitHub user vkorukanti opened a pull request:

    https://github.com/apache/drill/pull/211

    DRILL-3938: Support reading from Hive tables that have schema altered after the creation

    Hive creates a converter to convert from the partition schema to table schema when the
table schema is altered after the partition is created. The behavior in mapping partition
schema to table schema is:
     - if a column doesn't exist in partition schema, its value is considered as null
     - if the column type doesn't match the required type, it is converted according to various
convert methods available in Hive.
    
    Currently we have to rely on the Hive converters, because Drill doesn't have the same
convert methods that Hive has [1]. 
    
    [1] https://github.com/apache/hive/blob/branch-1.0/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
    
    Also:
    + Remove "redoRecord" logic which is not needed after "automatic reallocation" (DRILL-1960)
changes.
    + Remove HiveTestRecordReader. This is incomplete in implementation and not used anywhere.
It is currently just
      a burden to maintain with changes in its superclass HiveRecordReader

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vkorukanti/drill DRILL-3938

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #211
    
----
commit 21c4325abcb25ce22846217e61eee23816f73571
Author: vkorukanti <venki.korukanti@gmail.com>
Date:   2015-10-19T18:35:09Z

    DRILL-3938: Support reading from Hive tables that have schema altered after the creation
    
    Also:
    + Remove "redoRecord" logic which is not needed after "automatic reallocation" (DRILL-1960)
changes.
    + Remove HiveTestRecordReader. This is incomplete in implementation and not used anywhere.
It is currently just
      a burden to maintain with changes in its superclass HiveRecordReader

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message