drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew (JIRA)" <j...@apache.org>
Subject [jira] [Created] (DRILL-3882) Time and Timestamp vectors should not return timezone-based data
Date Thu, 01 Oct 2015 20:42:26 GMT
Andrew created DRILL-3882:
-----------------------------

             Summary: Time and Timestamp vectors should not return timezone-based data
                 Key: DRILL-3882
                 URL: https://issues.apache.org/jira/browse/DRILL-3882
             Project: Apache Drill
          Issue Type: Bug
          Components: Storage - Other
    Affects Versions: 1.1.0
            Reporter: Andrew
            Assignee: Andrew
             Fix For: 1.2.0


TimeVector, NullableTimeVector, TimestampVector, and NullableTimestampVector should not return
values that contain timezone information. Each of these classes implements:
{code}
public DateTime getObject()
{code}

I believe the correct method should be
{code}
public LocalTime getObject()
{code}

The rational for this change is that the "time" and "timestamp" types are not timezone-aware
and therefore are more closely modeled by Joda's LocalTime class.

Additionally, the way it is now makes testing harder b/c {code}TestBuilder{code} wants to
use {code}DateTime{code} objects to compare results from JDBC storage engines, but the storage
engine's return no timezone information for such types.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message