drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julien Le Dem <jul...@dremio.com>
Subject Re: Maven/checkstyle changes
Date Wed, 28 Oct 2015 17:50:28 GMT
Daniel,
If you move the config for the checkstyle plugin out of the executions tag,
you can run mvn checkstyle:check
See:
https://github.com/apache/drill/commit/eefbaa448ab15974d5e63cf37615ce20bb436ba2
It'll be part of:

On Wed, Oct 28, 2015 at 10:37 AM, Julien Le Dem <julien@dremio.com> wrote:

> Hi Daniel,
> I moved checkstyle to the verify phase that comes after the tests and
> before package:
>
> https://maven.apache.org/guides/introduction/introduction-to-the-lifecycle.html
> This is the default binding for checkstyle:
> https://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html
> This has been part of the modifications to speedup the build.
> mvn test should be as fast as possible.
> I think rat should be moved to verify as well as it slows down running
> tests (especially if you're running a single one)
>
>
>
> On Wed, Oct 28, 2015 at 10:13 AM, Daniel Barclay <dbarclay@maprtech.com>
> wrote:
>
>> Hey, what changed in the Maven setup regarding checkstyle?
>>
>> I used to be able to run "mvn validate" to run checkstyle to find
>> style violations up front (e.g., before starting a long test run).
>>
>> However, that doesn't seem to work any more.  It looks like checkstyle
>> is run later, but it's not clear in what Maven phase or step.
>>
>>
>> How do we run checkstyle (without building everything) now?
>>
>> Thanks,
>> Daniel
>> --
>> Daniel Barclay
>> MapR Technologies
>>
>
>
>
> --
> Julien
>



-- 
Julien

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message