drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: Initial version of RecordIterator and MergeJoi...
Date Fri, 30 Oct 2015 22:29:37 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/190#discussion_r43559169
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
---
    @@ -403,14 +325,14 @@ private JoinWorker generateNewWorker() throws ClassTransformationException,
IOEx
               outputType = inputType;
             }
             JVar vvIn = cg.declareVectorValueSetupAndMember("incomingLeft",
    -                                                        new TypedFieldId(inputType, vectorId));
    +          new TypedFieldId(inputType, vectorId));
    --- End diff --
    
    Probably. I didn't check the code but that sounds like the right thing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message