drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3232: Handle promoting writers and vecto...
Date Fri, 30 Oct 2015 05:05:58 GMT
Github user jacques-n commented on a diff in the pull request:

    https://github.com/apache/drill/pull/207#discussion_r43472119
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/FunctionGenerationHelper.java
---
    @@ -127,7 +133,7 @@ protected static boolean isComparableType(MajorType type) {
     
       private static String formatCanNotCompareMsg(MajorType left, MajorType right) {
         StringBuilder sb = new StringBuilder();
    -    sb.append("Map, Array or repeated scalar type should not be used in group by, order
by or in a comparison operator. Drill does not support compare between ");
    +    sb.append("Map, Array, Union or repeated scalar type should not be used in group
by, order by or in a comparison operator. Drill does not support compare between ");
    --- End diff --
    
    Union here seems like a problem. The two values could very much be comparable. Shouldn't
this just be a reasonably large case statement?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message