drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sudheeshkatkam <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3963 Add Sequence file support.
Date Thu, 29 Oct 2015 23:00:23 GMT
Github user sudheeshkatkam commented on a diff in the pull request:

    https://github.com/apache/drill/pull/214#discussion_r43455354
  
    --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/impersonation/TestImpersonationQueries.java
---
    @@ -179,6 +199,15 @@ private static void createView(final String viewOwner, final String
viewGroup, f
         assertEquals(viewPerms, status.getPermission().toShort());
       }
     
    +  private static void createView(final String viewOwner, final String viewGroup, final
String viewName,
    --- End diff --
    
    Any reason why (protected version of) this method cannot be moved to BaseTestImpersonation?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message