drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jacques-n <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3623: Use shorter query path for LIMIT 0...
Date Thu, 29 Oct 2015 02:49:40 GMT
Github user jacques-n commented on the pull request:

    https://github.com/apache/drill/pull/193#issuecomment-152056732
  
    I'm sorry to say that I'm -1 on this change
    
    It seems to be adding a planning rewrite rule where there should be a simple fix execution
bug. Let's just fix the execution bug. 
    
    Limit 0 should complete its execution the moment it receives a schema (as part of fast
schema). It doesn't need to receive any records. You just described a situation where it is
waiting for records from a blocking operator. That shouldn't be the case. If there is some
other real benefit to this change after that execution bug is fixed, let's revisit in that
light.
    
    If you think I'm misunderstanding your description of the execution behavior or the dynamics
involved, please help me to better understand. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message