drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julienledem <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3983: Small test improvements
Date Tue, 27 Oct 2015 17:46:12 GMT
Github user julienledem commented on the pull request:

    https://github.com/apache/drill/pull/221#issuecomment-151584120
  
    @adeneche I'm all for removing verbose logging. In this case, it sounds like we should
go after bad logging rather than removing information from errors. 
    Having "verbose errors" will actually enable less logging:
    Currently the server side (drillbit) stack trace is lost when the exception goes through
the RPC layer. Which means we rely on logging those errors on the server side to find the
original stack trace.
    the "verbose errors" setting will add the stacktrace in the exception message so that
we get both the client and server side stacktrace from the client side exception. which would
allow removing the server side logging in tests.
    
    I think we should follow this general principle: If an exception is dealt with it should
not be logged. Only exception that can not be dealt with should be logged as errors or warning
depending on the effect.
    A negative test would catch an exception and verify it. If logging happens at some layer
bellow it, this sounds like it should be refactored.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message