drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From julienledem <...@git.apache.org>
Subject [GitHub] drill pull request: DRILL-3742: Classpath scanning
Date Fri, 23 Oct 2015 21:36:40 GMT
Github user julienledem commented on a diff in the pull request:

    https://github.com/apache/drill/pull/148#discussion_r42917147
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalOperatorUtil.java
---
    @@ -33,14 +32,10 @@
     
       private PhysicalOperatorUtil() {}
     
    -  public synchronized static Class<?>[] getSubTypes(final DrillConfig config) {
    -    final Class<?>[] ops =
    -        PathScanner.scanForImplementationsArr(PhysicalOperator.class,
    -            config.getStringList(CommonConstants.PHYSICAL_OPERATOR_SCAN_PACKAGES));
    -    final String lineBrokenList =
    -        ops.length == 0 ? "" : "\n\t- " + Joiner.on("\n\t- ").join(ops);
    -    logger.debug("Found {} physical operator classes: {}.", ops.length,
    -                 lineBrokenList);
    +  public synchronized static Set<Class<? extends PhysicalOperator>> getSubTypes(ScanResult
classpathScan) {
    --- End diff --
    
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message