drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: Add Sequence file support.
Date Wed, 21 Oct 2015 21:25:36 GMT
Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/214#discussion_r42684543
  
    --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.java
---
    @@ -58,7 +58,8 @@
         HBASE_SUB_SCAN(33),
         WINDOW(34),
         NESTED_LOOP_JOIN(35),
    -    AVRO_SUB_SCAN(36);
    +    AVRO_SUB_SCAN(36),
    --- End diff --
    
    I think the queries may run fine, but the use of this protobuf definition if I'm not mistaken
is to generate query profiles. If you don't return a value that Drill knows about from the
method  getReaderOperatorType(), then the operator type will show up as unknown in the profile.
I should have been clearer, my comment was more a question to @StevenMPhillips and @jacques-n.
I think we may need to refactor this interface to just return a String and not use the protobuf
enum, or have a separate "notes" field if we want to have a generic filescan operator ID in
this enum with extra data to say what kind of scan we used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message