drill-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jaltekruse <...@git.apache.org>
Subject [GitHub] drill pull request: Add Sequence file support.
Date Wed, 21 Oct 2015 21:06:53 GMT
Github user jaltekruse commented on a diff in the pull request:

    https://github.com/apache/drill/pull/214#discussion_r42682341
  
    --- Diff: protocol/src/main/java/org/apache/drill/exec/proto/beans/CoreOperatorType.java
---
    @@ -58,7 +58,8 @@
         HBASE_SUB_SCAN(33),
         WINDOW(34),
         NESTED_LOOP_JOIN(35),
    -    AVRO_SUB_SCAN(36);
    +    AVRO_SUB_SCAN(36),
    --- End diff --
    
    Is this actually required to make this work? If it is we need to find a way to remove
modifying this protobuf definition as a requirement for adding a format plugin, because this
removes the ability for format plugins to truely be drop-in pluggable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message